Makefile.in - Issue 488002: Cleaning up google-breakpad source code of signed-unsigned comparison warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: Makefile.in

Issue 488002: Cleaning up google-breakpad source code of signed-unsigned comparison warnings (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/

Patch Set: Changeing the return type of GetCount to be signed int Created 12 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Makefile.in

===================================================================

--- Makefile.in (revision 1082)

+++ Makefile.in (working copy)

@@ -80,7 +80,8 @@

@GCC_TRUE@ -Werror=vla \

@GCC_TRUE@ -Werror=unused-variable \

@GCC_TRUE@ -Werror=missing-braces \

-@GCC_TRUE@ -Werror=overloaded-virtual

+@GCC_TRUE@ -Werror=overloaded-virtual \

+@GCC_TRUE@ -Werror=sign-compare

# Build as PIC on Linux, for linux_client_unittest_shlib

@@ -148,7 +149,7 @@

@ANDROID_HOST_TRUE@@LINUX_HOST_TRUE@am__append_16 = src/common/android/breakpad_getcontext.S \

@ANDROID_HOST_TRUE@@LINUX_HOST_TRUE@ src/common/android/breakpad_getcontext_unittest.cc

@ANDROID_HOST_TRUE@@LINUX_HOST_TRUE@am__append_17 = \

-@ANDROID_HOST_TRUE@@LINUX_HOST_TRUE@ -llog

+@ANDROID_HOST_TRUE@@LINUX_HOST_TRUE@ -llog -lm

@ANDROID_HOST_TRUE@@LINUX_HOST_TRUE@am__append_18 = \

@ANDROID_HOST_TRUE@@LINUX_HOST_TRUE@ -llog

« no previous file with comments | « Makefile.am ('k') | src/client/linux/handler/exception_handler.cc » ('j') | no next file with comments »