src/google_breakpad/processor/stack_frame_cpu.h - Issue 459002: Refactor the logic of resolving source line info into helper class

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: src/google_breakpad/processor/stack_frame_cpu.h

Issue 459002: Refactor the logic of resolving source line info into helper class (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/src/

Patch Set: Patch to another svn client with write permission. Created 12 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/google_breakpad/processor/stack_frame_cpu.h

===================================================================

--- src/google_breakpad/processor/stack_frame_cpu.h (revision 1067)

+++ src/google_breakpad/processor/stack_frame_cpu.h (working copy)

@@ -70,7 +70,7 @@

CONTEXT_VALID_ALL = -1

};

- StackFrameX86()

+ StackFrameX86()

: context(),

context_validity(CONTEXT_VALID_NONE),

windows_frame_info(NULL),

@@ -220,7 +220,7 @@

// Return the ContextValidity flag for register rN.

static ContextValidity RegisterValidFlag(int n) {

return ContextValidity(1 << n);

- }

+ }

// Register state. This is only fully valid for the topmost frame in a

// stack. In other frames, the values of nonvolatile registers may be

« no previous file with comments | « src/google_breakpad/processor/minidump_processor.h ('k') | src/google_breakpad/processor/stackwalker.h » ('j') | no next file with comments »