Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(444)

Unified Diff: src/processor/stackwalker_ppc.h

Issue 459002: Refactor the logic of resolving source line info into helper class (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/src/
Patch Set: Patch to another svn client with write permission. Created 12 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/processor/stackwalker_ppc.cc ('k') | src/processor/stackwalker_sparc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/processor/stackwalker_ppc.h
===================================================================
--- src/processor/stackwalker_ppc.h (revision 1067)
+++ src/processor/stackwalker_ppc.h (working copy)
@@ -53,23 +53,22 @@
// register state corresponding to the innermost called frame to be
// included in the stack. The other arguments are passed directly through
// to the base Stackwalker constructor.
- StackwalkerPPC(const SystemInfo *system_info,
- const MDRawContextPPC *context,
- MemoryRegion *memory,
- const CodeModules *modules,
- SymbolSupplier *supplier,
- SourceLineResolverInterface *resolver);
+ StackwalkerPPC(const SystemInfo* system_info,
+ const MDRawContextPPC* context,
+ MemoryRegion* memory,
+ const CodeModules* modules,
+ StackFrameSymbolizer* frame_symbolizer);
private:
// Implementation of Stackwalker, using ppc context (stack pointer in %r1,
// saved program counter in %srr0) and stack conventions (saved stack
// pointer at 0(%r1), return address at 8(0(%r1)).
virtual StackFrame* GetContextFrame();
- virtual StackFrame* GetCallerFrame(const CallStack *stack);
+ virtual StackFrame* GetCallerFrame(const CallStack* stack);
// Stores the CPU context corresponding to the innermost stack frame to
// be returned by GetContextFrame.
- const MDRawContextPPC *context_;
+ const MDRawContextPPC* context_;
};
« no previous file with comments | « src/processor/stackwalker_ppc.cc ('k') | src/processor/stackwalker_sparc.cc » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted