Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Unified Diff: src/common/string_conversion.cc

Issue 453002: Turn on more warnings in ios / mac projects. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Patch Set: Created 12 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/common/mac/macho_walker.cc ('k') | src/tools/linux/symupload/sym_upload.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/common/string_conversion.cc
===================================================================
--- src/common/string_conversion.cc (revision 1034)
+++ src/common/string_conversion.cc (working copy)
@@ -115,7 +115,7 @@
}
static inline u_int16_t Swap(u_int16_t value) {
- return (value >> 8) | (value << 8);
+ return (value >> 8) | static_cast<uint16_t>(value << 8);
}
string UTF16ToUTF8(const vector<u_int16_t> &in, bool swap) {
« no previous file with comments | « src/common/mac/macho_walker.cc ('k') | src/tools/linux/symupload/sym_upload.cc » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted