Issue 426002: Remove some linux libc calls from client library (take2)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 426002: Remove some linux libc calls from client library (take2) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by digit

Modified:
12 years, 3 months ago

Reviewers:
Ted Mielczarek, Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
https://google-breakpad.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

SORRY. It seems I've screwed up my commit for
http://breakpad.appspot.com/411002/, since revision 1001 only contains the new
src/client/linux/linux_libc_support.cc and none of the other required files.

I'm not sure what happened, but I'm re-uploading the patch has another issue.

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1002

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	Makefile.am	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	Makefile.in	View	21 chunks	+112 lines, -77 lines	0 comments	Download
M	android/google_breakpad/Android.mk	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/client/linux/minidump_writer/directory_reader.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/client/linux/minidump_writer/line_reader.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/client/linux/minidump_writer/linux_dumper.cc	View	5 chunks	+8 lines, -8 lines	0 comments	Download
M	src/client/linux/minidump_writer/linux_ptrace_dumper.cc	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/client/linux/minidump_writer/minidump_writer.cc	View	22 chunks	+47 lines, -45 lines	0 comments	Download
M	src/common/linux/linux_libc_support.h	View	2 chunks	+29 lines, -112 lines	0 comments	Download
M	src/common/linux/linux_libc_support_unittest.cc	View	2 chunks	+38 lines, -0 lines	0 comments	Download