common/linux/elf_symbols_to_module_unittest.cc - Issue 400002: Mechanical change to allow the co-existance of std::string with a global ::string class

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: common/linux/elf_symbols_to_module_unittest.cc

Issue 400002: Mechanical change to allow the co-existance of std::string with a global ::string class (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/src/

Patch Set: Extended the impact of this change to a couple of more files under src/client Created 12 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: common/linux/elf_symbols_to_module_unittest.cc

===================================================================

--- common/linux/elf_symbols_to_module_unittest.cc (revision 973)

+++ common/linux/elf_symbols_to_module_unittest.cc (working copy)

@@ -42,6 +42,7 @@

#include "common/linux/synth_elf.h"

#include "common/module.h"

#include "common/test_assembler.h"

+#include "common/using_std_string.h"

using google_breakpad::Module;

using google_breakpad::synth_elf::StringTable;

@@ -52,7 +53,6 @@

using google_breakpad::test_assembler::Section;

using ::testing::Test;

using ::testing::TestWithParam;

-using std::string;

using std::vector;

class ELFSymbolsToModuleTestFixture {

« no previous file with comments | « common/linux/elf_core_dump_unittest.cc ('k') | common/linux/file_id_unittest.cc » ('j') | no next file with comments »