src/common/test_assembler.h - Issue 399002: The end goal of this change is to boost the test coverage of breakpad in Google

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: src/common/test_assembler.h

Issue 399002: The end goal of this change is to boost the test coverage of breakpad in Google (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/src/

Patch Set: Fixing a comment duplication and reverting a scoped_array usage Created 12 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/common/test_assembler.h

===================================================================

--- src/common/test_assembler.h (revision 977)

+++ src/common/test_assembler.h (working copy)

@@ -271,8 +271,11 @@

public:

Section(Endianness endianness = kUnsetEndian)

: endianness_(endianness) { };

- ~Section() { };

+ // A base class destructor should be either public and virtual,

+ // or protected and nonvirtual.

+ virtual ~Section() { };

// Set the default endianness of this section to ENDIANNESS. This

// sets the behavior of the D<N> appending functions. If the

// assembler's default endianness was set, this is the

« no previous file with comments | « src/common/memory_unittest.cc ('k') | src/processor/synth_minidump_unittest.cc » ('j') | no next file with comments »