Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Unified Diff: src/client/linux/minidump_writer/minidump_writer.cc

Issue 39003: Use MD_MODULE_SIZE in place of sizeof(MDRawModule). This is Chromium commit 2... (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Patch Set: Created 15 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/tools/linux/md2core/minidump-2-core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/client/linux/minidump_writer/minidump_writer.cc
===================================================================
--- src/client/linux/minidump_writer/minidump_writer.cc (revision 429)
+++ src/client/linux/minidump_writer/minidump_writer.cc (working copy)
@@ -510,7 +510,7 @@
}
TypedMDRVA<uint32_t> list(&minidump_writer_);
- if (!list.AllocateObjectAndArray(num_output_mappings, sizeof(MDRawModule)))
+ if (!list.AllocateObjectAndArray(num_output_mappings, MD_MODULE_SIZE))
return false;
dirent->stream_type = MD_MODULE_LIST_STREAM;
@@ -523,7 +523,7 @@
continue;
MDRawModule mod;
- my_memset(&mod, 0, sizeof(mod));
+ my_memset(&mod, 0, MD_MODULE_SIZE);
mod.base_of_image = mapping.start_addr;
mod.size_of_image = mapping.size;
const size_t filepath_len = my_strlen(mapping.name);
@@ -579,7 +579,7 @@
return false;
mod.module_name_rva = ld.rva;
- list.CopyIndexAfterObject(j++, &mod, sizeof(mod));
+ list.CopyIndexAfterObject(j++, &mod, MD_MODULE_SIZE);
}
return true;
« no previous file with comments | « no previous file | src/tools/linux/md2core/minidump-2-core.cc » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted