Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(131)

Issue 381001: Fix MIPS support

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by chrisdearman
Modified:
12 years, 7 months ago
Reviewers:
zodiac, Ryan Sleevi
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Fix MIPS support

* LSS_ERRNO may involve a function call so LSS_RETURN must preserve $v0 value
* syscall clobbers $25/t9
* __v0 needs "+r" constraint when it contains the system call number
* Simplified and made consistent the O32 versions of syscall5/syscall6
* __r7 needs "+r" constraint in clone syscall
* __r7/__v1 need "+r" constraint in pipe syscall

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/third_party/lss/linux_syscall_support.h View 6 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 3
chrisdearman
This change has been submitted upstream: rhttp://code.google.com/p/linux-syscall-support/issues/detail?id=4 I don't see the change in a clean ...
12 years, 7 months ago #1
Ryan Sleevi
You don't need to patch this file. Instead, the svn:externals need to be updated run: ...
12 years, 7 months ago #2
Ryan Sleevi
12 years, 7 months ago #3
On 2012/04/27 02:30:56, Ryan Sleevi wrote:
> You don't need to patch this file. Instead, the svn:externals need to be
updated
> 
> run:
> svn propset svn:externals

propget ... GET, not set :)

> http://google-breakpad.googlecode.com/svn/trunk/src/third_party and you'll see
> that 'lss' is checked out at -r7
> 
> This should be updated to -r10 (which has your patch)
> 
> A committer can do this via
> 
> svn propedit svn:externals [svn read/write path]/trunk/src/third_party
> 
> and then committing the update
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted