Add partial unit tests for dwarf2reader::CompilationUnit.

This is really incomplete --- it's just what's needed to get started
testing support for the DWARF 4 attribute forms.

[jimb]

Here's the first patch in the fix for issue 461.

[Ted Mielczarek]

This code makes my eyes glaze over a bit, but I don't see anything that looks
obviously bad.

http://breakpad.appspot.com/342002/diff/1/4
File src/common/dwarf/dwarf2reader_die_unittest.cc (right):

http://breakpad.appspot.com/342002/diff/1/4#newcode107
Line 107: class MockCompilationUnit: public Section {
I don't know that I'd name this MockCompilationUnit, since you're not actually
mocking its methods with Google Mock.

http://breakpad.appspot.com/342002/diff/1/4#newcode197
Line 197: };
Do you think these two classes would be useful to unit tests outside of this
file? Should they be in a header or a common test file?

http://breakpad.appspot.com/342002/diff/1/4#newcode247
Line 247: size_t format_size;                   // 32-bit or 64-bit DWARF
Might be clearer to say 4 or 8 bytes here, right?

http://breakpad.appspot.com/342002/diff/1/4#newcode375
Line 375: struct DwarfForms: public DwarfFormsFixture, public
TestWithParam<DwarfHeaderParams> { };
Is this line over 80 characters?

[jimb]

Okay, version 3 of the patch implements everything you requested. Look okay?

[Ted Mielczarek]

On 2012/01/20 22:54:01, jimb wrote:
> Okay, version 3 of the patch implements everything you requested. Look okay?

LGTM