src/client/linux/minidump_writer/minidump_writer_unittest.cc - Issue 334001: Replace readlink calls with a safer version that guarantees NULL-termination.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: src/client/linux/minidump_writer/minidump_writer_unittest.cc

Issue 334001: Replace readlink calls with a safer version that guarantees NULL-termination. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/

Patch Set: '' Created 13 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/client/linux/minidump_writer/minidump_writer_unittest.cc

===================================================================

--- src/client/linux/minidump_writer/minidump_writer_unittest.cc (revision 895)

+++ src/client/linux/minidump_writer/minidump_writer_unittest.cc (working copy)

@@ -42,6 +42,7 @@

#include "client/linux/minidump_writer/minidump_writer.h"

#include "common/linux/eintr_wrapper.h"

#include "common/linux/file_id.h"

+#include "common/linux/safe_readlink.h"

#include "common/tests/auto_tempdir.h"

#include "google_breakpad/processor/minidump.h"

@@ -287,8 +288,8 @@

// Locate helper binary next to the current binary.

char self_path[PATH_MAX];

- if (readlink("/proc/self/exe", self_path, sizeof(self_path) - 1) == -1) {

- FAIL() << "readlink failed: " << strerror(errno);

+ if (!SafeReadLink("/proc/self/exe", self_path)) {

+ FAIL() << "readlink failed";

exit(1);

}

string helper_path(self_path);

« no previous file with comments | « src/client/linux/minidump_writer/linux_dumper_unittest.cc ('k') | src/common/linux/file_id_unittest.cc » ('j') | no next file with comments »