Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 320001: Merge trunk r875 to the chrome_15 branch (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by Mark Mentovai
Modified:
4 years, 10 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/branches/chrome_15/
Visibility:
Public.

Description

Merge trunk r875 to the chrome_15 branch.

Fix some shadow variables, including one in file_id.cc that causes all files to
generate the same hash. Add a test to make sure this doesn't happen again.

Review URL: http://breakpad.appspot.com/316002

Original patch by Lei Zhang <thestig@chromium.org>

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/minidump_writer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/common/linux/file_id.cc View 5 chunks +7 lines, -11 lines 0 comments Download
M src/common/linux/file_id_unittest.cc View 2 chunks +101 lines, -0 lines 0 comments Download
M src/common/stabs_reader.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/processor/source_line_resolver_base.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/tools/linux/md2core/minidump-2-core.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2
Mark Mentovai
7 years ago #1
Lei Zhang (chromium)
7 years ago #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted