src/processor/stackwalker.cc - Issue 314001: Use frame pointer to walk ARM stack on iOS.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: src/processor/stackwalker.cc

Issue 314001: Use frame pointer to walk ARM stack on iOS. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/

Patch Set: '' Created 13 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/processor/stackwalker.cc

===================================================================

--- src/processor/stackwalker.cc (revision 868)

+++ src/processor/stackwalker.cc (working copy)

@@ -44,6 +44,7 @@

#include "google_breakpad/processor/source_line_resolver_interface.h"

#include "google_breakpad/processor/stack_frame.h"

#include "google_breakpad/processor/symbol_supplier.h"

+#include "google_breakpad/processor/system_info.h"

#include "processor/linked_ptr.h"

#include "processor/logging.h"

#include "processor/scoped_ptr.h"

@@ -187,10 +188,13 @@

break;

case MD_CONTEXT_ARM:

+ int fp_register = -1;

+ if (system_info->os_short == "ios")

+ fp_register = MD_CONTEXT_ARM_REG_IOS_FP;

cpu_stackwalker = new StackwalkerARM(system_info,

context->GetContextARM(),

- memory, modules, supplier,

- resolver);

+ fp_register, memory, modules,

+ supplier, resolver);

break;

}

« no previous file with comments | « src/google_breakpad/common/minidump_cpu_arm.h ('k') | src/processor/stackwalker_arm.cc » ('j') | no next file with comments »