Issue 301002: Fix stupid parameter shadowing bug in Linux File ID code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 301002: Fix stupid parameter shadowing bug in Linux File ID code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by Ted Mielczarek

Modified:
13 years, 6 months ago

Reviewers:
Lei Zhang (chromium)

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

In my patch in r830 I introduced a stupid bug by shadowing a function parameter
with a local variable, which would cause the Linux file ID code to use the first
PROGBITS section it encountered to generate the file ID, instead of .text. This
simple patch fixes it (and I added a test).

Patch Set 1 #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/linux/file_id.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
	M	src/common/linux/file_id_unittest.cc	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages