Issue 286003: correct fix for strtok_r

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 286003: correct fix for strtok_r

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by albertzeyer

Modified:
12 years, 9 months ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/processor/basic_source_line_resolver.cc	View		1 chunk	+81 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

albertzeyer

strtok_r was bad before. This change made the processor working for me under Windows.

13 years, 6 months ago #1

albertzeyer

strtok_r was bad before. This change made the processor working for me under Windows.

13 years, 6 months ago #2

Ted Mielczarek

12 years, 9 months ago #3

Is this on top of another patch? My local copy of basic_source_line_resolver.cc
doesn't have that #define.

Also, I think it'd be better to use strtok_s here instead of inlining a
definition of strtok_r:
http://msdn.microsoft.com/en-us/library/ftsafwz3%28v=vs.80%29.aspx

Expand All Messages | Collapse All Messages