Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 249001: Add missing constructor to CPPLanguage. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by rafael.espindola
Modified:
8 years, 4 months ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

CPPLanguage is missing a user defined constructor,
but in language.cc a const variable of this type is defined.

This is not valid c++. Since is non-POD as it has a base class and from the
standard:

From the standard:

[class] p4

A POD-struct is an aggregate class that has no non-static data members of type
non-POD-struct, non-POD-union (or array of such types) or reference, and has no
user-declared copy assignment operator and no user-declared destructor.

[dcl.init.aggr]

An aggregate is an array or a class (clause 9) with no user-declared
constructors (12.1), no private or protected non-static data members (clause
11), no base classes (clause 10), and no virtual functions (10.3).


For more information see.
http://clang.llvm.org/compatibility.html#default_init_const

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/language.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1
rafael.espindola
8 years, 5 months ago #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted