Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Issue 243001: Allow HTTPUpload to submit zero-byte files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by Ted Mielczarek
Modified:
7 years ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

We get a fair amount of crash reports on Windows that fail to submit because we
get a zero-byte minidump file. I suspect most of these are due to
MinidumpWriteDump allocating memory and our process being near or at OOM.
Allowing the zero-byte minidumps to be submitted would at least let us gauge the
size of the problem.

Patch Set 1 #

Patch Set 2 : Without extraneous files #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/windows/http_upload.cc View 3 chunks +4 lines, -5 lines 1 comment Download
M src/common/windows/http_upload.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Ted Mielczarek
7 years ago #1
Ted Mielczarek
7 years ago #2
Mark Mentovai
7 years ago #3
LGTM

http://breakpad.appspot.com/243001/diff/3001/4001
File src/common/windows/http_upload.cc (right):

http://breakpad.appspot.com/243001/diff/3001/4001#newcode341
Line 341: file.seekg(0, ios::beg);
Fix the indent on these two lines while you’re here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted