Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123)

Issue 215001: Double stack scanning length in stackwalker (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by Ted Mielczarek
Modified:
14 years, 1 month ago
Reviewers:
jimb
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

We currently only scan 15 words deep on the stack. This patch doubles that to 30
to let the stack walker try a bit harder.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/google_breakpad/processor/stackwalker.h View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/stackwalker_x86_unittest.cc View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Ted Mielczarek
14 years, 1 month ago #1
jimb
14 years, 1 month ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted