Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(50)

Unified Diff: src/tools/mac/crash_report/on_demand_symbol_supplier.mm

Issue 162001: In on_demand_symbol_supplier, recognize architecture x86 and transform it to i386 (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Patch Set: Created 14 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/tools/mac/crash_report/on_demand_symbol_supplier.mm
===================================================================
--- src/tools/mac/crash_report/on_demand_symbol_supplier.mm (revision 661)
+++ src/tools/mac/crash_report/on_demand_symbol_supplier.mm (working copy)
@@ -251,7 +251,15 @@
length:module_path.length()];
DumpSymbols dump;
if (dump.Read(module_str)) {
- if (dump.SetArchitecture(system_info->cpu)) {
+ // What Breakpad calls "x86" should be given to the system as "i386".
+ std::string architecture;
+ if (system_info->cpu.compare("x86") == 0) {
+ architecture = "i386";
+ } else {
+ architecture = system_info->cpu;
+ }
+
+ if (dump.SetArchitecture(architecture)) {
FILE *file = fopen([symbol_path fileSystemRepresentation],"w");
if (file) {
dump.WriteSymbolFile(file);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted