Issue 156001: Change ClientInfo into a class to match other platforms

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 156001: Change ClientInfo into a class to match other platforms (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by Ted Mielczarek

Modified:
15 years, 1 month ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

The ClientInfo implementation I used doesn't map very well to what we do on
other platforms. This changes it into a class and renames the current ClientInfo
struct to an ExceptionInfo struct.

Patch Set 1 #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/mac/crash_generation/client_info.h	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	src/client/mac/crash_generation/crash_generation_client.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/client/mac/crash_generation/crash_generation_server.cc	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	src/client/mac/crash_generation/crash_generation_server.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/client/mac/tests/crash_generation_server_test.cc	View	3 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages