Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Unified Diff: src/common/module_unittest.cc

Issue 130001: Cleans up mac projects, and builds everything 64 bit (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Patch Set: Addressed Mark's latest comments Created 14 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/common/module_unittest.cc
===================================================================
--- src/common/module_unittest.cc (revision 623)
+++ src/common/module_unittest.cc (working copy)
@@ -49,7 +49,7 @@
// Return a FILE * referring to a temporary file that will be deleted
// automatically when the stream is closed or the program exits.
-FILE *checked_tmpfile() {
+static FILE *checked_tmpfile() {
FILE *f = tmpfile();
if (!f) {
fprintf(stderr, "error creating temporary file: %s\n", strerror(errno));
@@ -60,7 +60,7 @@
// Read from STREAM until end of file, and return the contents as a
// string.
-string checked_read(FILE *stream) {
+static string checked_read(FILE *stream) {
string contents;
int c;
while ((c = getc(stream)) != EOF)
@@ -74,7 +74,7 @@
}
// Apply 'fflush' to STREAM, and check for errors.
-void checked_fflush(FILE *stream) {
+static void checked_fflush(FILE *stream) {
if (fflush(stream) == EOF) {
fprintf(stderr, "error flushing temporary file stream: %s\n",
strerror(errno));
@@ -83,7 +83,7 @@
}
// Apply 'fclose' to STREAM, and check for errors.
-void checked_fclose(FILE *stream) {
+static void checked_fclose(FILE *stream) {
if (fclose(stream) == EOF) {
fprintf(stderr, "error closing temporary file stream: %s\n",
strerror(errno));
@@ -91,7 +91,7 @@
}
}
-Module::Function *generate_duplicate_function(const string &name) {
+static Module::Function *generate_duplicate_function(const string &name) {
const Module::Address DUP_ADDRESS = 0xd35402aac7a7ad5cLL;
const Module::Address DUP_SIZE = 0x200b26e605f99071LL;
const Module::Address DUP_PARAMETER_SIZE = 0xf14ac4fed48c4a99LL;
« src/common/module.h ('K') | « src/common/module.h ('k') | src/common/string_conversion.cc » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted