src/common/mac/macho_reader_unittest.cc - Issue 130001: Cleans up mac projects, and builds everything 64 bit

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: src/common/mac/macho_reader_unittest.cc

Issue 130001: Cleans up mac projects, and builds everything 64 bit (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/

Patch Set: Addressed Mark's latest comments Created 14 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/common/mac/macho_reader_unittest.cc

===================================================================

--- src/common/mac/macho_reader_unittest.cc (revision 623)

+++ src/common/mac/macho_reader_unittest.cc (working copy)

@@ -992,7 +992,7 @@

EXPECT_FALSE(reader.big_endian());

EXPECT_EQ(CPU_TYPE_X86, reader.cpu_type());

EXPECT_EQ(CPU_SUBTYPE_I386_ALL, reader.cpu_subtype());

- EXPECT_EQ(MH_EXECUTE, reader.file_type());

+ EXPECT_EQ(static_cast<uint32_t>(MH_EXECUTE), reader.file_type());

EXPECT_EQ(FileFlags(MH_TWOLEVEL |

MH_DYLDLINK |

MH_NOUNDEFS),

@@ -1018,7 +1018,7 @@