src/client/windows/crash_generation/crash_generation_server.cc - Issue 1254002: Fix crash in Windows CrashGenerationServer from r1274.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: src/client/windows/crash_generation/crash_generation_server.cc

Issue 1254002: Fix crash in Windows CrashGenerationServer from r1274. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/

Patch Set: Created 11 years ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/client/windows/crash_generation/crash_generation_server.cc

===================================================================

--- src/client/windows/crash_generation/crash_generation_server.cc (revision 1286)

+++ src/client/windows/crash_generation/crash_generation_server.cc (working copy)

@@ -121,7 +121,7 @@

upload_request_callback_(upload_request_callback),

upload_context_(upload_context),

generate_dumps_(generate_dumps),

- dump_path_(*dump_path),

+ dump_path_(dump_path ? *dump_path : L""),

server_state_(IPC_SERVER_STATE_UNINITIALIZED),

shutting_down_(false),

overlapped_(),

« no previous file with comments | « no previous file | no next file » | no next file with comments »