Issue 1164002: Update GTM and enable -Wundef and strict C++11 flags

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1164002: Update GTM and enable -Wundef and strict C++11 flags (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by dmaclach

Modified:
11 years, 1 month ago

Reviewers:
Ivan Penkov

CC:
google-breakpad_googlecode.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/ios/Breakpad.xcodeproj/project.pbxproj	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	src/client/mac/handler/minidump_generator.cc	View	5 chunks	+14 lines, -7 lines	0 comments	Download
M	src/client/minidump_file_writer.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/common/mac/GTMDefines.h	View	6 chunks	+28 lines, -16 lines	0 comments	Download
D	src/common/mac/GTMGarbageCollection.h	View	1 chunk	+0 lines, -72 lines	0 comments	Download
M	src/common/mac/GTMLogger.m	View	2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 2

Ivan Penkov

11 years, 1 month ago #2

On 2014/02/25 20:48:29, dmaclach wrote:
> PTAL

Confirming that this patch resolves the Mac build issue that I saw earlier.

LGTM.