Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 10674002: Add GYP build for the src/tools directory on Mac and Linux. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by rsesek
Modified:
10 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add GYP build for the src/tools directory on Mac and Linux.

This GYP-ifies the src/processor and src/common directories on those platforms
as well. The Makefile build uses much more granular unittest executables, so
the new processor_unittests does not yet link because of multiple main()
symbols,
but this will be fixed later.

Update issue 575

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
A src/build/all.gyp View 1 chunk +41 lines, -0 lines 0 comments Download
M src/build/common.gypi View 9 chunks +5 lines, -111 lines 0 comments Download
A src/build/filename_rules.gypi View 1 chunk +57 lines, -0 lines 0 comments Download
A src/build/gyp_breakpad View 1 chunk +67 lines, -0 lines 0 comments Download
A src/build/testing.gypi View 1 chunk +90 lines, -0 lines 0 comments Download
A src/common/common.gyp View 1 chunk +240 lines, -0 lines 0 comments Download
A src/processor/processor.gyp View 1 chunk +175 lines, -0 lines 0 comments Download
A src/processor/processor_tools.gypi View 1 chunk +57 lines, -0 lines 0 comments Download
A src/third_party/libdisasm/libdisasm.gyp View 1 chunk +64 lines, -0 lines 0 comments Download
A src/tools/linux/tools_linux.gypi View 1 chunk +83 lines, -0 lines 0 comments Download
M src/tools/mac/crash_report/on_demand_symbol_supplier.mm View 1 chunk +1 line, -1 line 0 comments Download
A src/tools/mac/tools_mac.gypi View 1 chunk +116 lines, -0 lines 0 comments Download
A src/tools/tools.gyp View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsesek
10 years, 4 months ago #1
Mark Mentovai
LGTM
10 years, 4 months ago #2
rsesek
10 years, 4 months ago #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1358 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted