Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8674)

Issue 349002: Support @ (alignment) operator in PostfixEvaluator (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by Ted Mielczarek
Modified:
12 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Visual C++ 2010 produces debug symbols with program strings that include a new
operator: @, which is for alignment. This patch adds support for the @ operator.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated patch #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/processor/postfix_evaluator-inl.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M src/processor/postfix_evaluator.h View 1 1 chunk +6 lines, -4 lines 0 comments Download
M src/processor/postfix_evaluator_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5
Ted Mielczarek
I always forget that "send mail" is not the default.
12 years, 1 month ago #1
Mark Mentovai
http://breakpad.appspot.com/349002/diff/1/src/processor/postfix_evaluator-inl.h File src/processor/postfix_evaluator-inl.h (right): http://breakpad.appspot.com/349002/diff/1/src/processor/postfix_evaluator-inl.h#newcode133 src/processor/postfix_evaluator-inl.h:133: result = operand1 & (((ValueType)-1) ^ (operand2 - 1)); ...
12 years, 1 month ago #2
Ted Mielczarek
I updated the patch, but forgot to --send-mail, as usual.
12 years, 1 month ago #3
Mark Mentovai
LGTM
12 years, 1 month ago #4
Mark Mentovai
12 years, 1 month ago #5
And congratulations.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted