Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 30001: Fix compilation of OS X handler on PPC with 10.5 SDK (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by Ted Mielczarek
Modified:
15 years, 1 month ago
Reviewers:
mochalatte
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

With the 10.5 SDK, the ppc_thread_state_t struct prefixes register names with
__, just like the x86 struct. This patch just switches the PPC code paths to use
the REGISTER_FROM_THREADSTATE macro that we're already using for x86, and tweaks
the ifdefs around it to do the right thing in these situations. This builds fine
for me in a ppc/x86 universal build against the 10.4 and 10.5 SDKs.

Neal, this looks like it conflicts with your patch over on
http://breakpad.appspot.com/24001/show , but it accomplishes the same aim, I
think. Can you take a look? We checked in something similar to this in our
source tree just to fix PPC breakage.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
src/client/mac/handler/minidump_generator.cc View 3 chunks +4 lines, -17 lines 0 comments Download
src/client/mac/handler/minidump_generator.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Ted Mielczarek
15 years, 1 month ago #1
mochalatte
15 years, 1 month ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted