Issue 24001: 64-bit CL for Breakpad on OS X

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 24001: 64-bit CL for Breakpad on OS X

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by mochalatte

Modified:
15 years, 7 months ago

Reviewers:
mmentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/mac/Breakpad.xcodeproj/project.pbxproj	View	39 chunks	+323 lines, -7 lines	0 comments	Download
M	src/client/mac/handler/breakpad_nlist_64.cc	View	4 chunks	+8 lines, -5 lines	0 comments	Download
M	src/client/mac/handler/dynamic_images.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/client/mac/handler/minidump_generator.cc	View	7 chunks	+34 lines, -20 lines	0 comments	Download
M	src/common/mac/dump_syms.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/common/mac/macho_utilities.h	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/common/mac/macho_walker.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/common/mac/string_utilities.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/tools/mac/crash_report/on_demand_symbol_supplier.mm	View	1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

mochalatte

15 years, 7 months ago #1

Hi Mark

With this CL, we can generate 64-bit minidumps from in-process with module
lists, however symbol generation still needs to be worked on and there were some
slight discrepancies in the minidump compared to GDB's backtrace.  But we can
start the review now.

Thanks,

Neal

Expand All Messages | Collapse All Messages