Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Results

Newer ›

	Subject	Owner	Reviewers	Comments	Last updated
643002	Remove define of mach_vm_region from mach_vm_compatibility.h. (Closed)	blundell	qsr		10 years, 6 months
642002	Support symbol dumping for ARMV8 iOS apps. (Closed)	blundell	Mark Mentovai, qsr		10 years, 6 months
586002	Try getting file-ids from memory when possible, and fallback to reading files otherwise	glandium	Ted Mielczarek, vapier	9	10 years, 6 months
626002	Fixing minidump_dump to handle nacl dumps. (Closed)	bradnelson	Mark Mentovai, mseaborn		10 years, 7 months
578002	Find (and store) DT_DEBUG data in linux_dumper instead of minidump_writer	glandium	Ted Mielczarek		10 years, 9 months
571003	Set minidump special module debug name for linux-gate at the minidump_writer level instead of linux…	glandium	Ted Mielczarek	3	10 years, 9 months
562002	Use device and inode to uniquely identify files behind mappings	glandium	Ted Mielczarek		10 years, 9 months
550002	Make all linux ptrace dumper tests use a subprocess (Closed)	glandium	Ted Mielczarek	4	10 years, 9 months
581002	Use std::vector with a custom allocator wrapping PageAllocator for wasteful_vector (Closed)	glandium	Ted Mielczarek, thakis	1	10 years, 9 months
573002	Move mappings aggregation and reordering from linux_dumper to minidump_writer	glandium	Ted Mielczarek	3	10 years, 10 months
582002	Ensure a proper LinuxDumper::crash_thread_ value (Closed)	glandium	Ted Mielczarek		10 years, 11 months
585002	Fix build failure in functioninfo.cc (Closed)	glandium	Ted Mielczarek		10 years, 11 months
580002	Remove the API to pass known memory mappings to MinidumpWriter and ExceptionHandler	glandium	Ted Mielczarek	2	10 years, 11 months
592003	Fix a "set but not used" compiler warning in a test (Closed)	mseaborn	Mark Mentovai	2	10 years, 11 months
595002	Fix ELF build ID getter to check the ELF note's namespace string	mseaborn	Mark Mentovai	3	10 years, 11 months
594002	Fix a "set but not used" compiler warning in libdisasm (Closed)	mseaborn	Mark Mentovai		10 years, 11 months
591002	Make x86-64 stack walking work for Native Client minidumps (Closed)	mseaborn	Mark Mentovai, bradnelson		10 years, 11 months
590002	Add MD_OS_NACL platform_id value for identifying NaCl minidumps (Closed)	mseaborn	Mark Mentovai, bradnelson		10 years, 11 months
588003	Fix an "unused variable" compiler warning in exploitability_win.cc (Closed)	mseaborn	Mark Mentovai		10 years, 11 months
589002	dump_syms: Fix load address calculation for prelinked DSOs/PIEs	mseaborn	Roland McGrath, Mark Mentovai		10 years, 11 months

Newer ›