Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(91)

Issue 275001: Output PUBLIC lines from export symbols on Linux (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by Ted Mielczarek
Modified:
8 years, 7 months ago
Reviewers:
jimb
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

For cases where we don't have debug symbols, dump_syms currently won't produce
any output on Linux. This patch makes it able to output the contents of the
symbol table as PUBLIC lines instead. I noticed that there aren't currently unit
tests for dump_symbols.cc, and I made a fair amount of changes here, so my next
plan is to write unit tests for that.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 3 chunks +5 lines, -0 lines 0 comments Download
M Makefile.in View 11 chunks +58 lines, -2 lines 0 comments Download
M src/common/linux/dump_symbols.cc View 5 chunks +51 lines, -5 lines 0 comments Download
A src/common/linux/elf_symbols_to_module.cc View 1 chunk +160 lines, -0 lines 3 comments Download
A src/common/linux/elf_symbols_to_module.h View 1 chunk +58 lines, -0 lines 0 comments Download
A src/common/linux/elf_symbols_to_module_unittest.cc View 1 chunk +368 lines, -0 lines 1 comment Download

Messages

Total messages: 6
Ted Mielczarek
8 years, 10 months ago #1
jimb
Hi, Ted --- looks great! (And the code looks somehow familiar...) I did have some ...
8 years, 7 months ago #2
Ted Mielczarek
On 2011/07/05 18:48:53, jimb wrote: > Did you run the tests under valgrind? I hadn't, ...
8 years, 7 months ago #3
Ted Mielczarek
http://breakpad.appspot.com/275001/diff/1/5 File src/common/linux/elf_symbols_to_module.cc (right): http://breakpad.appspot.com/275001/diff/1/5#newcode131 Line 131: return reinterpret_cast<const char *>(strings.start + offset); On 2011/07/05 ...
8 years, 7 months ago #4
jimb
On 2011/07/06 15:37:08, Ted Mielczarek wrote: > I did this, I used memchr anyway, since ...
8 years, 7 months ago #5
Ted Mielczarek
8 years, 7 months ago #6
On 2011/07/06 16:01:48, jimb wrote:
> On 2011/07/06 15:37:08, Ted Mielczarek wrote:
> > I did this, I used memchr anyway, since this code is in src/common/linux. If
> > someone wants to make it work on another platform they can worry about it
> then.
> 
> Uh, you mean "memrchr", right?

I managed to type it correctly in the patch, just not here! :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted