Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 248001: Rename duplicated argument name (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by rafael.espindola
Modified:
8 years, 4 months ago
Reviewers:
Ted Mielczarek
CC:
tmielczarek_mozilla.com, google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Duplicated argument names are illegal in C++, but gcc unfortunately accepts them
in declarations. This is a clang compatibility issue and is explained in

http://clang.llvm.org/compatibility.html#param_name_lookup

This patch just renames the duplicates.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename all the duplicates. #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/handler/exception_handler.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5
Ted Mielczarek
http://breakpad.appspot.com/248001/diff/1/2 File src/client/mac/handler/exception_handler.cc (right): http://breakpad.appspot.com/248001/diff/1/2#newcode129 Line 129: thread_state_t thread_state, You changed thread_state_count but not thread_state. ...
8 years, 5 months ago #1
rafael.espindola
> You changed thread_state_count but not thread_state. Did you mean to change > both? Yes, ...
8 years, 5 months ago #2
rafael.espindola
8 years, 5 months ago #3
rafael.espindola
Just subscribed to google-breakpad-dev. Lest see if it works now :-)
8 years, 5 months ago #4
Ted Mielczarek
8 years, 5 months ago #5
On 2011/01/05 16:30:07, rafael.espindola wrote:
> Just subscribed to google-breakpad-dev. Lest see if it works now :-)

This LGTM. I'll land it for you along with your other couple of patches once I
get around to reviewing them all, ok,?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted