Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1335)

Unified Diff: src/client/linux/handler/exception_handler_unittest.cc

Issue 1624002: Add flags to control the amount of information written to Linux minidump files
Patch Set: Build against the latest code and address all review issues. Add a way to control the maximum threa… Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/client/linux/handler/exception_handler.h ('k') | src/client/linux/minidump_writer/minidump_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/client/linux/handler/exception_handler_unittest.cc
===================================================================
--- src/client/linux/handler/exception_handler_unittest.cc (revision 1401)
+++ src/client/linux/handler/exception_handler_unittest.cc (working copy)
@@ -566,7 +566,7 @@
memset(prefix_bytes, 0, sizeof(prefix_bytes));
memset(suffix_bytes, 0, sizeof(suffix_bytes));
EXPECT_TRUE(memcmp(bytes, prefix_bytes, sizeof(prefix_bytes)) == 0);
- EXPECT_TRUE(memcmp(bytes + kOffset, kIllegalInstruction,
+ EXPECT_TRUE(memcmp(bytes + kOffset, kIllegalInstruction,
sizeof(kIllegalInstruction)) == 0);
EXPECT_TRUE(memcmp(bytes + kOffset + sizeof(kIllegalInstruction),
suffix_bytes, sizeof(suffix_bytes)) == 0);
@@ -655,7 +655,7 @@
uint8_t suffix_bytes[kMemorySize / 2 - sizeof(kIllegalInstruction)];
memset(suffix_bytes, 0, sizeof(suffix_bytes));
- EXPECT_TRUE(memcmp(bytes + kOffset, kIllegalInstruction,
+ EXPECT_TRUE(memcmp(bytes + kOffset, kIllegalInstruction,
sizeof(kIllegalInstruction)) == 0);
EXPECT_TRUE(memcmp(bytes + kOffset + sizeof(kIllegalInstruction),
suffix_bytes, sizeof(suffix_bytes)) == 0);
@@ -981,8 +981,9 @@
AutoTempDir temp_dir;
string templ = temp_dir.path() + "/exception-handler-unittest";
+ ContentFlags flags = DUMP_ALL;
ASSERT_TRUE(WriteMinidump(templ.c_str(), crashing_pid, context,
- kCrashContextSize));
+ kCrashContextSize, flags, -1));
static const char b = 0;
ASSERT_EQ(1, (HANDLE_EINTR(write(signal_fd, &b, 1))));
ASSERT_EQ(0, close(signal_fd));
« no previous file with comments | « src/client/linux/handler/exception_handler.h ('k') | src/client/linux/minidump_writer/minidump_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted