Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Issues

‹ Newer 21 - 40 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
3794002	Fix compatibility with Android NDK r10d. (Closed)	primiano	rmcilroy, fdegans	5	9 years, 2 months
7814002	Make breakpad compatible with Android NDK r10d. (Closed)	primiano	rmcilroy, fdegans		9 years, 2 months
10714002	Microdump writer: stop using new/malloc in compromised context (Closed)	primiano	Lei Zhang (chromium)		9 years, 2 months
9784002	Fix Windows dump_syms x64 linking (Closed)	Ted Mielczarek	Mark Mentovai	1	9 years, 2 months
8684002	Support building src/tools/linux/dump_syms/dump_syms on OS X	jaysoffian	Ted Mielczarek, Mark Mentovai	2	9 years, 2 months
2854003	Write out the actual THUMB function addresses for externs on ARM.	Lei Zhang (chromium)	hashimoto		9 years, 2 months
9774002	Add stack contents output functionality to minidump_stackwalk (Closed)	hashimoto	Mark Mentovai, Ted Mielczarek	2	9 years, 2 months
7804002	WIP (Closed)	hashimoto			9 years, 2 months
9764002	Update license on convert_UTF.* to the standard Unicode license (Closed)	Mark Mentovai	Ted Mielczarek		9 years, 2 months
7794002	Add option to Breakpad to consume INVALID_HANDLE_VALUE exceptions. (Closed)	Will Harris	Mark Mentovai		9 years, 2 months
7784002	Add default debug file search paths to Linux dump_syms.	Lei Zhang (chromium)			9 years, 3 months
3784002	Cleanup Linux debug link file handling code. (Closed)	Lei Zhang (chromium)	Mark Mentovai, Ted Mielczarek		9 years, 3 months
7774002	Handle ARM THUMB functions when removing duplicate PUBLIC entries. (Closed)	Lei Zhang (chromium)	Mark Mentovai, hashimoto, Ted Mielczarek	6	9 years, 3 months
3754003	Fix overflow error in breakpad for linux	kjoswiak	Mark Mentovai, markus	1	9 years, 3 months
3774002	Add unit tests for overlapping functions and externs. (Closed)	Lei Zhang (chromium)	Mark Mentovai, Ted Mielczarek		9 years, 3 months
2844002	Follow debug link correctly (Closed)	hashimoto	Ted Mielczarek, vapier, Lei Zhang (chromium), Ben Chan, Mark Mentovai	4	9 years, 3 months
2854002	Demangle symbol name (Closed)	hashimoto	Mark Mentovai	4	9 years, 3 months
4714002	Refactor common code for ensuring core dump for unit tests.	Ben Chan	Mark Mentovai, vapier, Lei Zhang (chromium)	7	9 years, 3 months
4724002	Handle failures of copying process data from a core file. (Closed)	Ben Chan	Mark Mentovai, vapier, Lei Zhang (chromium)	9	9 years, 3 months
3764002	Add a unit test for generating a minidump from a core dump on Linux.	Ben Chan	vapier, Lei Zhang (chromium)	3	9 years, 3 months

‹ Newer 21 - 40 Older ›