Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4127)

Issue 71001: Breakpad Mac dumper: Build cleanly as a 64-bit program. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by jimb
Modified:
14 years ago
Reviewers:
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Since we're using its types, #include <stdint.h>.

Don't cast 'void *' to 'uint32_t' where we need to do byte-pointer
arithmetic. Instead, use 'char *'; the language guarantees that
sizeof(char) == 1.

To make the above easier, pass pointers to byte buffers as 'char *', not
'void *.

Use natural pointer arithmetic where possible. If ptr is a 'struct A *', then
write:
        (struct B *) (ptr + 1)
instead of:
        (struct B *) ((char *) ptr + sizeof(struct A))
This helps us avoid (say) using the size of the 32-bit Mach-O header to
skip a 64-bit Mach-O header. (The latter has an extra 32-bit word at the
end.)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/mac/dump_syms.mm View 12 chunks +40 lines, -46 lines 0 comments Download
M src/common/mac/macho_walker.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2
jimb
With this, I can build the dumper on a 64-bit platform. I don't think it ...
14 years, 1 month ago #1
jimb
14 years ago #2
With the new Mac dumper patches I've just gotten working, this is obsoleted. 
Removing this from Neal's review queue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted