Breakpad Mac Dumper: Fix compilation warnings on OS X 10.6

Breakpad's Macintosh symbol dumper uses deprecated functions for
dealing with mixed-endianness code. This patch provides an overloaded
function, ByteSwap, that automatically chooses the CFSwap* functions
from <CoreFoundation/CFByteOrder.h> appropriate for its argument's
size.

[jimb]

Hi, Neal.  Don't mean to spam you with reviews; please feel free to reassign as
appropriate.

[jimb]

By the way, the new Mac dumper patches I've just gotten working (sort of)
obsolete all this, so I'm removing Neal as a reviewer here.

[jimb]

This one's ready to be reviewed now.

[jimb]

Added thestig as reviewer.

[Lei Zhang (chromium)]

Punting to Mark. Looks ok to me, but I know nothing about CFSwapInt and NXSwap.

[Mark Mentovai]

lgo

http://breakpad.appspot.com/70001/diff/4001/5001
File src/common/mac/byteswap.h (right):

http://breakpad.appspot.com/70001/diff/4001/5001#newcode36
Line 36: #ifndef COMMON_MAC_BYTESWAPP_H_
Extra pee?

http://breakpad.appspot.com/70001/diff/4001/5001#newcode39
Line 39: #include <CoreFoundation/CFByteOrder.h>
I’d prefer you just use <libkern/OSByteOrder.h> directly. This sort of implies
the need to link against the CoreFoundation framework, which isn’t really true
because everything in here is just a macro, but since there isn’t necessarily
anything Core Foundation-ish here, there’s no reason to use the macros from
CF-land.

http://breakpad.appspot.com/70001/diff/4001/5001#newcode48
Line 48: #endif // COMMON_MAC_BYTESWAP_H_
Nit: at least two spaces between the last real thing on a line and the // when
doing an in-line comment.

[jimb]

http://breakpad.appspot.com/70001/diff/4001/5001
File src/common/mac/byteswap.h (right):

http://breakpad.appspot.com/70001/diff/4001/5001#newcode39
Line 39: #include <CoreFoundation/CFByteOrder.h>
On 2010/04/27 18:49:29, Mark Mentovai wrote:
> I’d prefer you just use <libkern/OSByteOrder.h> directly. 

Done.

http://breakpad.appspot.com/70001/diff/4001/5001#newcode48
Line 48: #endif // COMMON_MAC_BYTESWAP_H_
On 2010/04/27 18:49:29, Mark Mentovai wrote:
> Nit: at least two spaces between the last real thing on a line and the // when
> doing an in-line comment.

Fixed here and elsewhere in the patch queue.

[Mark Mentovai]

Excellent. LGTM.

http://breakpad.appspot.com/70001/diff/17001/18001
File src/common/mac/byteswap.h (right):

http://breakpad.appspot.com/70001/diff/17001/18001#newcode39
Line 39: #include <libkern/OSByteOrder.h>
Update the change description to not reference the Core Foundation header, too.

[jimb]

Committed, r589.