Issue 66001: Breakpad processor: Support AMD64 stack unwinding driven by DWARF CFI.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 66001: Breakpad processor: Support AMD64 stack unwinding driven by DWARF CFI. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by jimb

Modified:
14 years, 1 month ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

This adds support for 'STACK CFI' records (DWARF CFI) to the AMD64
stack walker. This is necessary for the stack trace to include any
frames other than the youngest. Unit tests are included.

Patch Set 2 : Breakpad processor: Support AMD64 stack unwinding driven by DWARF CFI. #

Total comments: 1

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	Makefile.am	View		2 chunks	+15 lines, -0 lines	0 comments	Download
M	Makefile.in	View		11 chunks	+126 lines, -0 lines	0 comments	Download
M	src/google_breakpad/processor/stack_frame_cpu.h	View		1 chunk	+31 lines, -15 lines	0 comments	Download
M	src/processor/minidump_stackwalk.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/processor/stackwalker_amd64.cc	View	1	2 chunks	+99 lines, -39 lines	0 comments	Download
M	src/processor/stackwalker_amd64.h	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
A	src/processor/stackwalker_amd64_unittest.cc	View		1 chunk	+334 lines, -0 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jimb

Here's the AMD64 dumper. This one uses the same SimpleCFIWalker class that the x86 dumper ...

14 years, 1 month ago #1

Mark Mentovai

lg http://breakpad.appspot.com/66001/diff/1008/17 File src/processor/stackwalker_amd64_unittest.cc (right): http://breakpad.appspot.com/66001/diff/1008/17#newcode75 Line 75: system_info.os_version = "Horrendous Hippo"; :)

14 years, 1 month ago #4

Committed, r554.

Expand All Messages | Collapse All Messages