Issue 64001: Fix to cache NOT_FOUND results from symbol supplier on a per-minidump basis

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 64001: Fix to cache NOT_FOUND results from symbol supplier on a per-minidump basis (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by mochalatte

Modified:
14 years, 5 months ago

Reviewers:
brdevmn, Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Code reviwe comments addressed #

Patch Set 3 : removed some commented out code #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/google_breakpad/processor/stackwalker.h	View	1	3 chunks	+8 lines, -2 lines	0 comments	Download
M	src/processor/minidump_processor_unittest.cc	View	1 2	5 chunks	+57 lines, -0 lines	0 comments	Download
M	src/processor/stackwalker.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mochalatte

Hi Michael, Ted This change fixes the stackwalker to cache the NOT_FOUND results from a ...

14 years, 6 months ago #1

Ted Mielczarek

LGTM aside from comments below. http://breakpad.appspot.com/64001/diff/1/4 File src/google_breakpad/processor/stackwalker.h (right): http://breakpad.appspot.com/64001/diff/1/4#newcode147 Line 147: set<const CodeModule*> no_symbol_modules_; ...

14 years, 6 months ago #3

mochalatte

14 years, 6 months ago #4

Thanks for the review - checked in after addressing all comments.

http://breakpad.appspot.com/64001/diff/1/4
File src/google_breakpad/processor/stackwalker.h (right):

http://breakpad.appspot.com/64001/diff/1/4#newcode147
Line 147: set<const CodeModule*> no_symbol_modules_;
On 2010/02/25 13:36:19, Ted Mielczarek wrote:
> It seems a little weird to be keying on a pointer value here. If someone made
a
> copy of a CodeModule (using Copy()), then the new module wouldn't be found
here.
> Why not key on a string and use module->code_file() instead?

Done.

http://breakpad.appspot.com/64001/diff/1/3
File src/processor/minidump_processor_unittest.cc (right):

http://breakpad.appspot.com/64001/diff/1/3#newcode165
Line 165: class CountingSymbolSupplier : public SymbolSupplier {
On 2010/02/25 13:36:19, Ted Mielczarek wrote:
> This feels like it'd be cleaner with a Mock class and some expectations.

Done.

http://breakpad.appspot.com/64001/diff/1/3#newcode248
Line 248: printf("%s: %d\n", it->first.c_str(), it->second);
On 2010/02/25 13:36:19, Ted Mielczarek wrote:
> Seems like unnecessary test spew.

removed

Expand All Messages | Collapse All Messages