Issue 61001: Merge of Ted & I's ARM patches

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 61001: Merge of Ted & I's ARM patches

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by mochalatte

Modified:
14 years, 2 months ago

Reviewers:
nahor.j

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Fix automake/autoconf versions #

Patch Set 3 : Removed some extra logging #

Total comments: 2

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	Makefile.am	View	1	4 chunks	+38 lines, -3 lines	0 comments	Download
M	Makefile.in	View	1	20 chunks	+317 lines, -29 lines	2 comments	Download
M	src/client/linux/Makefile	View	1	5 chunks	+16 lines, -4 lines	0 comments	Download
M	src/client/linux/crash_generation/crash_generation_client.cc	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	src/client/linux/handler/exception_handler.cc	View	1 2	8 chunks	+22 lines, -10 lines	0 comments	Download
M	src/client/linux/handler/exception_handler.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/client/linux/handler/exception_handler_unittest.cc	View	1 2	3 chunks	+2 lines, -5 lines	0 comments	Download
M	src/client/linux/minidump_writer/linux_dumper.cc	View	1	7 chunks	+20 lines, -28 lines	0 comments	Download
M	src/client/linux/minidump_writer/linux_dumper.h	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	src/client/linux/minidump_writer/linux_dumper_unittest.cc	View	1	4 chunks	+66 lines, -15 lines	0 comments	Download
M	src/client/linux/minidump_writer/minidump_writer.cc	View	1	5 chunks	+60 lines, -1 line	0 comments	Download
M	src/common/linux/linux_syscall_support.h	View	1	19 chunks	+169 lines, -22 lines	0 comments	Download
M	src/config.h.in	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/processor/linked_ptr.h	View	1	3 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

nahor.j

14 years, 2 months ago #1

http://breakpad.appspot.com/61001/diff/49/1002
File Makefile.in (right):

http://breakpad.appspot.com/61001/diff/49/1002#newcode136
Line 136: src/common/string_conversion.lo
string_conversion is already listed in line 134.
This create linkage errors because some function are defined multiple times

http://breakpad.appspot.com/61001/diff/49/1002#newcode480
Line 480: src/common/string_conversion.cc
string_conversion already listed in line 477

Expand All Messages | Collapse All Messages