Issue 57002: Print ARM register values in minidump_stackwalk

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 57002: Print ARM register values in minidump_stackwalk (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by Ted Mielczarek

Modified:
14 years, 9 months ago

Reviewers:
mochalatte

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Simple patch, makes us print ARM register values in minidump_stackwalk output,
like we do for other architectures.

Patch Set 1 #

Total comments: 1

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
		src/processor/minidump_stackwalk.cc	View		2 chunks	+11 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

mochalatte

14 years, 9 months ago #2

http://breakpad.appspot.com/57002/diff/1/2
File src/processor/minidump_stackwalk.cc (right):

http://breakpad.appspot.com/57002/diff/1/2#newcode221
Line 221: if (frame_arm->context_validity & StackFrameARM::CONTEXT_VALID_R14)
what's R14 supposed to represent?  I thought R14 was the return address, whcih
is different from the registers that the other architectures are printing out.

Expand All Messages | Collapse All Messages