Issue 56002: Linux ARM handler / writer support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 56002: Linux ARM handler / writer support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by Ted Mielczarek

Modified:
14 years, 2 months ago

Reviewers:
mochalatte

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

This is a rough patch that adds support for ARM in the Linux exception handler /
minidump writer. It's got some TODOs in it, so it's not quite ready yet, but I
was able to generate a minidump on an N900 with this.

(This applies on top of Neal's patch from http://codereview.chromium.org/543125
)

Closed in favor of issue 61001.

Patch Set 1 #

Patch Set 2 : Updated patch #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
src/client/linux/Makefile	View	1	1 chunk	+1 line, -1 line	0 comments	Download
src/client/linux/handler/exception_handler.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
src/client/linux/minidump_writer/minidump_writer.cc	View	1	4 chunks	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Ted Mielczarek

14 years, 3 months ago #3

Neal, I think this is reviewable now. There's still some ugliness in there
around the floating point registers, but I'm not sure how to fix that. I'm ok
with punting on it, since we don't need it to get stack traces.

The other odd bit here is the Makefile change. We can't build those sender
tests/binaries because of the dependency on the checked-in binaries. I don't
have a good idea here, we either have to not build those by default or replace
the checked in binaries with svn:externals and compile those libraries from the
makefile.

Expand All Messages | Collapse All Messages