Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(458)

Issue 548002: Fix mingw compilation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by cjacek
Modified:
10 years ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Fix mingw compilation.

Currently breakpad doesn't have build system support for mingw. I have added
support for subset of the tree via autotools, mostly using its Linux variant.
The patch also fixes compilation of parts not covered by Makefile.am. Those were
tested in Mozilla tree with its build system. Code changes include:

- Lowercasing include files. This is for cross compilation on Linux, which is
case sensitive.

- Removed usage of stdext::checked_array_iterator, which is a MSVC-only
feature.

- Avoided using wstring-based ifstream APIs on GCC. It's stdc++ doesn't support
it.

Tested on both 32 and 64-bit Windows target.

Patch Set 1 #

Patch Set 2 : Fix mingw compilation. #

Patch Set 3 : rebased patch #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 2 25 chunks +33 lines, -26 lines 0 comments Download
M configure.ac View 1 chunk +7 lines, -0 lines 0 comments Download
M src/client/windows/common/auto_critical_section.h View 1 chunk +1 line, -1 line 0 comments Download
M src/client/windows/common/ipc_protocol.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/client/windows/crash_generation/client_info.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/client/windows/crash_generation/minidump_generator.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/client/windows/crash_generation/minidump_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/client/windows/handler/exception_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/client/windows/handler/exception_handler.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/common/linux/dump_symbols.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/common/windows/guid_string.h View 1 chunk +1 line, -1 line 0 comments Download
M src/common/windows/http_upload.cc View 1 3 chunks +9 lines, -5 lines 0 comments Download
M src/common/windows/http_upload.h View 1 3 chunks +9 lines, -4 lines 0 comments Download
M src/common/windows/pdb_source_line_writer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/google_breakpad/common/breakpad_types.h View 1 chunk +1 line, -1 line 0 comments Download
M src/google_breakpad/common/minidump_cpu_amd64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/google_breakpad/common/minidump_cpu_arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/google_breakpad/common/minidump_cpu_ppc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/google_breakpad/common/minidump_cpu_ppc64.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/google_breakpad/common/minidump_cpu_sparc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/google_breakpad/common/minidump_cpu_x86.h View 1 chunk +1 line, -1 line 0 comments Download
M src/google_breakpad/common/minidump_format.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/processor/binarystream.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/tools/windows/converter/ms_symbol_server_converter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/tools/windows/converter/ms_symbol_server_converter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/tools/windows/symupload/symupload.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
cjacek
11 years, 8 months ago #1
cjacek
Updated patch to clean up code pageconversion. It's similar to changes for Mozilla patch: https://bugzilla.mozilla.org/show_bug.cgi?id=856566
11 years, 7 months ago #2
cjacek
Ted, ping. Anything I can to help this get committed?
11 years, 6 months ago #3
Ted Mielczarek
Sorry, just need to find time to sit down and look at it. I'll try ...
11 years, 6 months ago #4
Ted Mielczarek
10 years ago #5
I reviewed this in Bugzilla here:
https://bugzilla.mozilla.org/show_bug.cgi?id=856566

It LGTM with some minor fixes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted