Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3031)

Issue 53010: Breakpad: Add minidump processor support for DWARF Call Frame Information. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by jimb
Modified:
14 years ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Add a CFIFrameInfo class (named for symmetry with WindowsFrameInfo) to
represent the set of STACK CFI rules in effect at a given instruction,
and apply them to a set of register values. Provide a SimpleCFIWalker
class template, to allow the essential CFI code to be shared amongst
the different architectures.

Teach BasicSourceLineResolver to partially parse 'STACK CFI' records,
and produce the set of rules in effect at a given instruction on
demand, by combining the initial rule set and the appropriate rule
deltas in a CFIFrameInfo object.

Adapt StackwalkerX86 and StackFrameX86 to retrieve, store, and apply
CFI stack walking information.

Add validity flags for all the general-purpose registers to
StackFrameX86::ContextValidity.

Patch Set 1 #

Patch Set 2 : Breakpad: Add minidump processor support for DWARF Call Frame Information. #

Patch Set 3 : Breakpad: Add minidump processor support for DWARF Call Frame Information. #

Total comments: 18

Patch Set 4 : Breakpad: Add minidump processor support for DWARF Call Frame Information. #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 5 chunks +21 lines, -0 lines 0 comments Download
M Makefile.in View 16 chunks +141 lines, -20 lines 0 comments Download
M src/google_breakpad/processor/basic_source_line_resolver.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/google_breakpad/processor/source_line_resolver_interface.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/google_breakpad/processor/stack_frame_cpu.h View 1 2 3 4 chunks +20 lines, -9 lines 0 comments Download
M src/processor/basic_source_line_resolver.cc View 1 2 3 7 chunks +126 lines, -2 lines 0 comments Download
M src/processor/basic_source_line_resolver_unittest.cc View 1 2 3 4 chunks +164 lines, -2 lines 0 comments Download
A src/processor/cfi_frame_info-inl.h View 1 2 3 1 chunk +119 lines, -0 lines 0 comments Download
A src/processor/cfi_frame_info.cc View 1 2 3 1 chunk +157 lines, -0 lines 0 comments Download
A src/processor/cfi_frame_info.h View 1 2 3 1 chunk +271 lines, -0 lines 0 comments Download
A src/processor/cfi_frame_info_unittest.cc View 1 2 3 1 chunk +531 lines, -0 lines 0 comments Download
M src/processor/stackwalker_x86.cc View 1 2 3 3 chunks +68 lines, -3 lines 0 comments Download
M src/processor/stackwalker_x86.h View 1 2 3 3 chunks +16 lines, -0 lines 0 comments Download
M src/processor/stackwalker_x86_unittest.cc View 1 2 3 7 chunks +209 lines, -20 lines 0 comments Download
M src/processor/testdata/module1.out View 1 chunk +6 lines, -0 lines 0 comments Download
M src/processor/testdata/module2.out View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8
jimb
This is the processor-side support for DWARF CFI.
14 years, 2 months ago #1
jimb
On 2010/01/30 01:12:24, jimb wrote: > This is the processor-side support for DWARF CFI. Updated ...
14 years, 2 months ago #2
Mark Mentovai
Pinging myself so that this floats back to the top of my inbox, improving the ...
14 years, 1 month ago #3
jimb
Patch set 3 changes the callee-saves flags on some of the x86 registers; this shouldn't ...
14 years, 1 month ago #4
Mark Mentovai
I like this very much. http://breakpad.appspot.com/53010/diff/4001/5005 File src/google_breakpad/processor/stack_frame_cpu.h (right): http://breakpad.appspot.com/53010/diff/4001/5005#newcode64 Line 64: CONTEXT_VALID_EAX = 1 ...
14 years, 1 month ago #5
jimb
Thanks for the review! http://breakpad.appspot.com/53010/diff/4001/5006 File src/processor/basic_source_line_resolver.cc (right): http://breakpad.appspot.com/53010/diff/4001/5006#newcode203 Line 203: // DWARF CFI stack ...
14 years, 1 month ago #6
jimb
Patch set 4 is revised for the above comments.
14 years, 1 month ago #7
jimb
14 years ago #8
Committed, r549.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted