Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(130)

Issue 53001: Breakpad Processor: Add new unit tests for google_breakpad::Minidump (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by jimb
Modified:
14 years, 6 months ago
Reviewers:
mochalatte
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

This also adds two new test utility class groups, TestAssembler and
SynthMinidump. These are overkill for what I'm doing with them here
(and may simply be overkill, period), but they make it easy to write
unit tests for code that works on binary files or raw memory contents
in a cross-platform way. I'm planning to use them for the DWARF CFI
unwinding tests and the DWARF CFI parser tests.

Patch Set 1 #

Patch Set 2 : Breakpad Processor: Add new unit tests for google_breakpad::Minidump #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 4 chunks +35 lines, -2 lines 0 comments Download
M Makefile.in View 1 12 chunks +335 lines, -4 lines 0 comments Download
M src/processor/minidump_unittest.cc View 1 3 chunks +437 lines, -6 lines 0 comments Download
A src/processor/synth_minidump.cc View 1 1 chunk +309 lines, -0 lines 0 comments Download
A src/processor/synth_minidump.h View 1 1 chunk +357 lines, -0 lines 0 comments Download
A src/processor/synth_minidump_unittest.cc View 1 1 chunk +280 lines, -0 lines 0 comments Download
A src/processor/synth_minidump_unittest_data.h View 1 1 chunk +246 lines, -0 lines 2 comments Download
A src/processor/test_assembler.cc View 1 1 chunk +354 lines, -0 lines 2 comments Download
A src/processor/test_assembler.h View 1 1 chunk +475 lines, -0 lines 0 comments Download
A src/processor/test_assembler_unittest.cc View 1 1 chunk +1643 lines, -0 lines 0 comments Download

Messages

Total messages: 5
jimb
A fresh version of this patch. The TestAssembler classes are used later by the DWARF ...
14 years, 7 months ago #1
jimb
Hi, just a ping on this one. The title of this issue may suggest that ...
14 years, 6 months ago #2
mochalatte
LGTM http://breakpad.appspot.com/53001/diff/2001/18 File src/processor/synth_minidump_unittest_data.h (right): http://breakpad.appspot.com/53001/diff/2001/18#newcode3 Line 3: // Not copyrightable: random test data. when ...
14 years, 6 months ago #3
jimb
Hi, Neal. Thanks for the review. I'm going to go ahead and land this; if ...
14 years, 6 months ago #4
jimb
14 years, 6 months ago #5
Committed, r547.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted