Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 46001: Allow Minidump class to be instantiated with stream instead of file (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 9 months ago by Ted Mielczarek
Modified:
14 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

We'd like to be able to process minidump data that's present in memory instead
of on disk. I've refactored the Minidump class slightly to allow a std::istream
to be passed in in the constructor instead of just a file. I added a very basic
minidump_unittest to ensure that reading from a file or from a std::stringstream
works.

Mark, can you take a look at this patch?

Patch Set 1 #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Makefile.am View 2 chunks +16 lines, -0 lines 2 comments Download
Makefile.in View 11 chunks +88 lines, -0 lines 1 comment Download
src/google_breakpad/processor/minidump.h View 4 chunks +9 lines, -4 lines 0 comments Download
src/processor/minidump.cc View 6 chunks +44 lines, -28 lines 6 comments Download
src/processor/minidump_unittest.cc View 1 chunk +102 lines, -0 lines 3 comments Download

Messages

Total messages: 3
Ted Mielczarek
14 years, 9 months ago #1
Mark Mentovai
http://breakpad.appspot.com/46001/diff/1/6 File Makefile.am (right): http://breakpad.appspot.com/46001/diff/1/6#newcode117 Line 117: src/processor/minidump_unittest \ sort: _u follows _s. http://breakpad.appspot.com/46001/diff/1/6#newcode155 Line ...
14 years, 9 months ago #2
Ted Mielczarek
14 years, 9 months ago #3
Committed in r438.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted