DescriptionPulls in gmock r263, gtest r368, and gyp r1472. Why upgrade: ================== 1. Gyp upgrade is required because the current version under src/tools doesn't recognize and support MSVC 2010 (version 10.0). 2. GTest upgrade is required because MSVC 2010 uses its own tr1 tuple and the MSVC version check in the GTest headers is fixed in a later revision (r364). 3. GMock upgrade is required because GMock pulls in GTest. Why these revisions: ===================== 1. Initially I was targeting the latest revisions for all. This worked fine for Gyp but not for GTest/GMock. 2. With the latest GTest I hit two issues and unfortunately I couldn't resolve the second one in a reasonable amount of time: - Needed to update the auto-make file to properly compile and link the pthread libraries. This was resolved fairly quickly. - The Windows client death tests (e.g. ASSERT_DEATH) are broken. I tried to debug it but it was taking too much time. 3. I decided to change course and try with the minimum versions of GMock/GTest that work fine. The minimum version of GMock that pulls in the GTest with the required fix is GMock r263. It pulls in GTest r368 (the fix we need is in GTest r364). Also, these revisions don't require any changes to the auto-make file (no pthread link issues - for now). Tests: ======== 1. Pre-checkin unittests (configure/make/make check) 2. Windows client unittests. Thanks, -Ivan Patch Set 1 #MessagesTotal messages: 3
|