Fixing a Windows compiler warning in src/client/windows/crash_generation/minidump_generator.cc

Apparently, a new Windows compiler warning (C4996: 'function': was declared
deprecated) was recently introduced in
src/client/windows/crash_generation/minidump_generator.cc.

The source file already contains a #pragma warning(disable) to disable the
warning, but the #pragma is not put on the right place.  The warning must be
disabled for both the caller and the function definition (which is in the
include file).  A possible workaround for current users of Google-breakpad is to
disable this particular warning at the project level however this is not ideal.

Instead of properly suppressing the warning I decided to just go ahead and fix
it.

Thanks,
-Ivan

[Ivan Penkov]

.

[Mark Mentovai]

LGTM

Does this mean that Microsoft considers the use of a standard form of std::copy
deprecated unless combined with a nonstandard extension? This is like _s all
over again. Great for cross-platform portability.

[Cris Neckar]

LGTM

[Ivan Penkov]

On 2012/08/16 12:45:04, Mark Mentovai wrote:
> LGTM
> 
> Does this mean that Microsoft considers the use of a standard form of
std::copy
> deprecated unless combined with a nonstandard extension? This is like _s all
> over again. Great for cross-platform portability.

It looks like it.  I just followed the advice they give on MSDN for resolution
of these warnings and this is what they suggest.