Allow the crash generation server to be initialized with a handle instead of a pipe name.

Allow the crash generation server to be initialized with a handle instead of a
pipe name.

This is useful when a crash handler needs to be added to a process that is
already sandboxed so that it cannot directly open the named pipe.

[Ted Mielczarek]

LGTM with a few nits fixed.

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/crash_generat...
File src/client/windows/crash_generation/crash_generation_client.cc (right):

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/crash_generat...
src/client/windows/crash_generation/crash_generation_client.cc:374: {
opening brace of functions goes at the end of the previous line.

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/crash_generat...
src/client/windows/crash_generation/crash_generation_client.cc:376: HANDLE
localPipe = CreateFile(pipe_name, kPipeDesiredAccess,
Google style for variable names is underscore_separated, not camelCase.

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/crash_generat...
src/client/windows/crash_generation/crash_generation_client.cc:379: if
(INVALID_HANDLE_VALUE != localPipe) {
The order of operands here is reversed compared to elsewhere in this file (like
ConnectToPipe up above).

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/crash_generat...
src/client/windows/crash_generation/crash_generation_client.cc:386: else {
} else {

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/handler/excep...
File src/client/windows/handler/exception_handler.cc (right):

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/handler/excep...
src/client/windows/handler/exception_handler.cc:151: if (pipe_name != NULL ||
pipe_handle != 0) {
You pass NULL as the missing pipe handle value, so maybe you should compare to
that as well for sanity?

[bsmedberg]

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/crash_generat...
File src/client/windows/crash_generation/crash_generation_client.cc (right):

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/crash_generat...
src/client/windows/crash_generation/crash_generation_client.cc:374: {
On 2012/06/29 20:05:26, Ted Mielczarek wrote:
> opening brace of functions goes at the end of the previous line.

Done.

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/crash_generat...
src/client/windows/crash_generation/crash_generation_client.cc:376: HANDLE
localPipe = CreateFile(pipe_name, kPipeDesiredAccess,
On 2012/06/29 20:05:26, Ted Mielczarek wrote:
> Google style for variable names is underscore_separated, not camelCase.

Done.

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/crash_generat...
src/client/windows/crash_generation/crash_generation_client.cc:379: if
(INVALID_HANDLE_VALUE != localPipe) {
On 2012/06/29 20:05:26, Ted Mielczarek wrote:
> The order of operands here is reversed compared to elsewhere in this file
(like
> ConnectToPipe up above).

Done, although I personally prefer const != lval to avoid accidental assigments.

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/crash_generat...
src/client/windows/crash_generation/crash_generation_client.cc:386: else {
On 2012/06/29 20:05:26, Ted Mielczarek wrote:
> } else {

Done.

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/handler/excep...
File src/client/windows/handler/exception_handler.cc (right):

http://breakpad.appspot.com/406002/diff/6001/src/client/windows/handler/excep...
src/client/windows/handler/exception_handler.cc:151: if (pipe_name != NULL ||
pipe_handle != 0) {
On 2012/06/29 20:05:26, Ted Mielczarek wrote:
> You pass NULL as the missing pipe handle value, so maybe you should compare to
> that as well for sanity?

Done.