Fix Android build of the client library.

Add Android NDK module definition + sample application

This patch adds a new directory named "android/" which contains
the following:

- A NDK build system module definition for the Google Breakpad
  client library. This can be used by developers using the ndk-build
  build system to more easily build and use the client library.

- A sample application demonstrating how to use the module,
  as well as test that the library works properly.

+ Updates to the README.ANDROID documentation.

[digit]

sorry, there was an operator error when uploading the second patch, I'll fix
this.

[digit]

On 2012/06/22 16:14:05, digit wrote:
> sorry, there was an operator error when uploading the second patch, I'll fix
> this.

sorry again for the annoyance. last patch is the right one. Thanks.

[Mark Mentovai]

http://breakpad.appspot.com/401002/diff/8001/README.ANDROID
File README.ANDROID (right):

http://breakpad.appspot.com/401002/diff/8001/README.ANDROID#newcode23
README.ANDROID:23: Usage instructions are the same than Linux.
than -> as

http://breakpad.appspot.com/401002/diff/8001/README.ANDROID#newcode25
README.ANDROID:25: Keep in mind that there is no /tmp on Android, so store your
mini-dumps
minidump is one word without a hyphen.

http://breakpad.appspot.com/401002/diff/8001/src/client/linux/android_ucontext.h
File src/client/linux/android_ucontext.h (right):

http://breakpad.appspot.com/401002/diff/8001/src/client/linux/android_ucontex...
src/client/linux/android_ucontext.h:42: // it is used to define struct
sigcontext properly.
This is a new sentence, so put a period at the end of the preceding line, and
start this one with a capital letter.

[digit]

http://breakpad.appspot.com/401002/diff/8001/README.ANDROID
File README.ANDROID (right):

http://breakpad.appspot.com/401002/diff/8001/README.ANDROID#newcode23
README.ANDROID:23: Usage instructions are the same than Linux.
On 2012/06/22 17:57:13, Mark Mentovai wrote:
> than -> as

Done.

http://breakpad.appspot.com/401002/diff/8001/README.ANDROID#newcode25
README.ANDROID:25: Keep in mind that there is no /tmp on Android, so store your
mini-dumps
On 2012/06/22 17:57:13, Mark Mentovai wrote:
> minidump is one word without a hyphen.

Done.

http://breakpad.appspot.com/401002/diff/8001/src/client/linux/android_ucontext.h
File src/client/linux/android_ucontext.h (right):

http://breakpad.appspot.com/401002/diff/8001/src/client/linux/android_ucontex...
src/client/linux/android_ucontext.h:42: // it is used to define struct
sigcontext properly.
On 2012/06/22 17:57:13, Mark Mentovai wrote:
> This is a new sentence, so put a period at the end of the preceding line, and
> start this one with a capital letter.

Done.

[Ted Mielczarek]

I don't know if it'd be worthwhile to have an Android.mk. I suspect that anyone
who has an app complex enough to bother shipping Breakpad probably has their own
build system setup anyway.

http://breakpad.appspot.com/401002/diff/8001/src/client/linux/android_ucontext.h
File src/client/linux/android_ucontext.h (right):

http://breakpad.appspot.com/401002/diff/8001/src/client/linux/android_ucontex...
src/client/linux/android_ucontext.h:44: #include <asm/sigcontext.h>
Was this hiding there all along? I think I did the first port against NDK r4 or
something. I don't remember being able to find a definition for struct
sigcontext anywhere in the NDK headers.

http://breakpad.appspot.com/401002/diff/8001/src/client/linux/handler/excepti...
File src/client/linux/handler/exception_handler.cc (left):

http://breakpad.appspot.com/401002/diff/8001/src/client/linux/handler/excepti...
src/client/linux/handler/exception_handler.cc:404: #else
This was apparently added in r945 with some other Android changes, but I don't
know why:
http://code.google.com/p/google-breakpad/source/detail?r=945

[digit]

http://breakpad.appspot.com/401002/diff/8001/src/client/linux/android_ucontext.h
File src/client/linux/android_ucontext.h (right):

http://breakpad.appspot.com/401002/diff/8001/src/client/linux/android_ucontex...
src/client/linux/android_ucontext.h:44: #include <asm/sigcontext.h>
NDK r4 was a *really* long time ago. The NDK headers have been considerably
updated. Actually, I think I should update the API level 3 signal.h to always
include this header too (I was NDK tech lead in a previous life). At least this
change should be future proof.

http://breakpad.appspot.com/401002/diff/8001/src/client/linux/handler/excepti...
File src/client/linux/handler/exception_handler.cc (left):

http://breakpad.appspot.com/401002/diff/8001/src/client/linux/handler/excepti...
src/client/linux/handler/exception_handler.cc:404: #else
I believe that at the time, Breakpad didn't use LSS, or the ARM version of its
sys_clone implementation didn't work, so we had to rely on the C library version
(which was only introduced in API level 9, i.e. Gingerbread).

I have a sample program that uses this code, which seems to work well.

[Mark Mentovai]

LGTM

[Ted Mielczarek]

On Fri, Jun 22, 2012 at 5:03 PM,  <digit@chromium.org> wrote:
>
http://breakpad.appspot.com/401002/diff/8001/src/client/linux/android_ucontex...
> src/client/linux/android_ucontext.h:44: #include <asm/sigcontext.h>
> NDK r4 was a *really* long time ago. The NDK headers have been
> considerably updated. Actually, I think I should update the API level 3
> signal.h to always include this header too (I was NDK tech lead in a
> previous life). At least this change should be future proof.

It's true, maybe it's not worth worrying about. I'm pretty sure we're
building with at least R6 or R7 on our build machines now.


>
http://breakpad.appspot.com/401002/diff/8001/src/client/linux/handler/excepti...
> src/client/linux/handler/exception_handler.cc:404: #else
> I believe that at the time, Breakpad didn't use LSS, or the ARM version
> of its sys_clone implementation didn't work, so we had to rely on the C
> library version (which was only introduced in API level 9, i.e.
> Gingerbread).

I don't think I believe either of those explanations, since my
original Android port had sys_clone here and it worked fine. (Also I
had to fix a bug in the ARM sys_clone when I first ported this stuff
to run on Maemo.)

> I have a sample program that uses this code, which seems to work well.

If I find some time I'll try updating the code and building Firefox
for Android with it. Doesn't look like you've made any major changes
so I wouldn't expect any problems.

-Ted

[digit]

Not sure how this project works. Am I supposed to wait for you guys to submit
this to the project? I don't see any "Commit" checkbox in this Rietvield
instance, and git-cl commit complains with "Operation not permitted".

Just checking. Thanks.

[Ted Mielczarek]

On Tue, Jun 26, 2012 at 4:10 AM,  <digit@chromium.org> wrote:
> Not sure how this project works. Am I supposed to wait for you guys to
> submit this to the project? I don't see any "Commit" checkbox in this
> Rietvield instance, and git-cl commit complains with "Operation not
> permitted".
>
> Just checking. Thanks.

You'll either need someone to commit it for you or to get Mark to add
you to the committer list on the project.

-Ted

[Mark Mentovai]

I already gave you access last week.

https://code.google.com/p/google-breakpad/source/checkout has instructions on
doing a read-write checkout. You need to check the source out with svn over
https and use your username (digit@chromium.org) and googlecode SVN password.
I’m not sure how that ties into git, but I’m sure you can figure it out based on
this information.

[digit]

Thanks, patch submitted in r973.