Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Side by Side Diff: google_breakpad/processor/code_module.h

Issue 400002: Mechanical change to allow the co-existance of std::string with a global ::string class (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/src/
Patch Set: Created 12 years, 9 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2006, Google Inc. 1 // Copyright (c) 2006, Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 18 matching lines...) Expand all
29 29
30 // code_module.h: Carries information about code modules that are loaded 30 // code_module.h: Carries information about code modules that are loaded
31 // into a process. 31 // into a process.
32 // 32 //
33 // Author: Mark Mentovai 33 // Author: Mark Mentovai
34 34
35 #ifndef GOOGLE_BREAKPAD_PROCESSOR_CODE_MODULE_H__ 35 #ifndef GOOGLE_BREAKPAD_PROCESSOR_CODE_MODULE_H__
36 #define GOOGLE_BREAKPAD_PROCESSOR_CODE_MODULE_H__ 36 #define GOOGLE_BREAKPAD_PROCESSOR_CODE_MODULE_H__
37 37
38 #include <string> 38 #include <string>
39
40 #include "common/using_std_string.h"
39 #include "google_breakpad/common/breakpad_types.h" 41 #include "google_breakpad/common/breakpad_types.h"
40 42
41 namespace google_breakpad { 43 namespace google_breakpad {
42 44
43 using std::string; 45 using std::string;
Mark Mentovai 2012/06/20 22:07:19 Get rid of this now.
ivanpe.google 2012/06/22 23:41:57 Good catch
44 46
45 class CodeModule { 47 class CodeModule {
46 public: 48 public:
47 virtual ~CodeModule() {} 49 virtual ~CodeModule() {}
48 50
49 // The base address of this code module as it was loaded by the process. 51 // The base address of this code module as it was loaded by the process.
50 // (u_int64_t)-1 on error. 52 // (u_int64_t)-1 on error.
51 virtual u_int64_t base_address() const = 0; 53 virtual u_int64_t base_address() const = 0;
52 54
53 // The size of the code module. 0 on error. 55 // The size of the code module. 0 on error.
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 // Creates a new copy of this CodeModule object, which the caller takes 87 // Creates a new copy of this CodeModule object, which the caller takes
86 // ownership of. The new CodeModule may be of a different concrete class 88 // ownership of. The new CodeModule may be of a different concrete class
87 // than the CodeModule being copied, but will behave identically to the 89 // than the CodeModule being copied, but will behave identically to the
88 // copied CodeModule as far as the CodeModule interface is concerned. 90 // copied CodeModule as far as the CodeModule interface is concerned.
89 virtual const CodeModule* Copy() const = 0; 91 virtual const CodeModule* Copy() const = 0;
90 }; 92 };
91 93
92 } // namespace google_breakpad 94 } // namespace google_breakpad
93 95
94 #endif // GOOGLE_BREAKPAD_PROCESSOR_CODE_MODULE_H__ 96 #endif // GOOGLE_BREAKPAD_PROCESSOR_CODE_MODULE_H__
OLDNEW

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted