Issue 378001: Reap child in VerifyStackReadWithMultipleThreads

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 378001: Reap child in VerifyStackReadWithMultipleThreads (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by chrisdearman

Modified:
12 years, 6 months ago

Reviewers:
Ben Chan

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Reap child in VerifyStackReadWithMultipleThreads

This avoids accumulating zombie processes when running
the test multiple times in a single test run.

Signed-off-by: Chris Dearman <chris@mips.com>

Patch Set 2 : Reap child in VerifyStackReadWithMultipleThreads #

Patch Set 3 : Reap child in VerifyStackReadWithMultipleThreads #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Ben Chan

http://breakpad.appspot.com/378001/diff/1/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc File src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc (right): http://breakpad.appspot.com/378001/diff/1/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc#newcode262 src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc:262: ASSERT_EQ(WTERMSIG(status), SIGKILL); according to gtest doc: ASSERT_EQ(expected, actual) i.e. ...

12 years, 7 months ago #1

Ben Chan

12 years, 7 months ago #4

On 2012/04/18 20:34:34, Ben Chan wrote:
> lgtm

Chris, looks like this patch has been committed @r956.  Could you close this
issue? Thanks.

Expand All Messages | Collapse All Messages